Reversing shadow intensity

Everything about the development of Urho3D.

Reversing shadow intensity

PostPosted by Modanung » 17 Apr 2016, 11:18

As it is now, Light::SetShadowIntensity works counter-intuitively to me. Do others feel this as well?
In my eyes a shadow is more intense if it is more visible and full black should be 1, not 0. The way the value is handled now I'd call it shadow transparency. I'd like to suggest to keep the name and reverse the scale.
for (Person* p : people)
ΞΞΞΞp->StopUsingWindows("https://www.linuxmint.com");
User avatar
Modanung
Active user
Active user
 
Posts: 171
Joined: 22 Jan 2015, 14:53
Location: The Netherlands

Re: Reversing shadow intensity

PostPosted by cadaver » 17 Apr 2016, 13:17

The accurate meaning of this value is "light intensity in shadow" (since there's only ever light addition in Urho's lighting passes, not reduction due to shadow) which is an easy fix in the header comment. Actually reversing the value would break existing scenes in which this attribute has been edited.
User avatar
cadaver
Urho3D author
Urho3D author
 
Posts: 1802
Joined: 16 Jan 2014, 14:52
Location: Finland

Re: Reversing shadow intensity

PostPosted by Modanung » 17 Apr 2016, 13:47

cadaver wrote:The accurate meaning of this value is "light intensity in shadow" (since there's only ever light addition in Urho's lighting passes, not reduction due to shadow)...

I see. I guess some things just confuse. ;)
for (Person* p : people)
ΞΞΞΞp->StopUsingWindows("https://www.linuxmint.com");
User avatar
Modanung
Active user
Active user
 
Posts: 171
Joined: 22 Jan 2015, 14:53
Location: The Netherlands


Return to Developer Talk

Who is online

Users browsing this forum: No registered users and 0 guests