NetSurf integration to Urho3D

Everything about the development of Urho3D.

Re: NetSurf integration to Urho3D

PostPosted by Lumak » 26 Oct 2016, 18:07

S.L.C wrote:Also, considering you'd have to link the engine to libjpeg, libpng and zlib. You might as well use those to read images and discard stb_image and jo_jpeg. Not that they have any significance to the final executable but they feel kinda redundant.


I agree. They are redundant. A better solution is to not link all those libraries in question but use STB lib and link with that instead. If you take a look at LibBrowser/netsurf folder, you'll also see that there are libnsgif and libnsbmp libraries. Instead of building those libraries where they are, they're brought local to 60_NetSurf/NetSurf folder. In addition, all image wrapper classes needed for netsurf: i.e. bmp.c, gif.c, jpeg.c, etc., are also brought local for the purpose of being able to wrap them with STB for Urho3D. But to do that, STB lib would have to be modified and that's something that I don't want to touch atm. In any case, I brought the image wrapper classes local to make it flexible for anyone porting netsurf to, perhaps, stand-alone SDL or other rendering libs other than using Urho3D.

Another flexibility in this setup is that for a stand-alone browser using Urho3D, all those image wrapper classes can be wrapped with Urho3D::Image class and SDL_Surfaces with Urho3D::UI components. Choices are there for w/e someone wants to do with this port.
Lumak
Have many posts
Have many posts
 
Posts: 425
Joined: 08 Jun 2015, 15:38

Re: NetSurf integration to Urho3D

PostPosted by S.L.C » 27 Oct 2016, 00:20

There might be a small problem though. Considering there are sites out there that use progressive jpeg images. STB might not be able to handle those.
User avatar
S.L.C
New user
New user
 
Posts: 14
Joined: 24 Dec 2014, 21:08

Re: NetSurf integration to Urho3D

PostPosted by Lumak » 27 Oct 2016, 14:26

You're absolutely right. But still, I have no desire to rewrite Urho3D::Image class and replace STB with libjpeg and other libs. I'll use the libs integrated in this project as they are. If someone wants to tackle this, they're more than welcome.
Lumak
Have many posts
Have many posts
 
Posts: 425
Joined: 08 Jun 2015, 15:38

Re: NetSurf integration to Urho3D

PostPosted by rku » 27 Oct 2016, 14:32

Browser itself supports only html 4 and css 2.1. I do not think lack of progressive jpeg support would be a major loss since browser is not suitable for casual web browsing anyhow.
User avatar
rku
Active user
Active user
 
Posts: 103
Joined: 06 May 2015, 08:24

Re: NetSurf integration to Urho3D

PostPosted by Enhex » 28 Oct 2016, 06:48

Licese is GPL, big nope.
@Lumark IANAL, but you probably already violated GPL by releasing your project under MIT, which isn't copyleft, which is required by GPL.
User avatar
Enhex
Most active user
Most active user
 
Posts: 325
Joined: 31 Dec 2014, 12:23

Re: NetSurf integration to Urho3D

PostPosted by Lumak » 28 Oct 2016, 08:40

Even though, I had this posted:
License
---
The MIT License (MIT)

See additional license infromation pertaining to NetSurf and other libraries in the subfolders.


due to so many different licenses, e.g. all subfolders prefixed with "lib" under libBrowser/netsurf/, e.g. libcss, libdom, libnsgif, etc., were all MIT license, duktape - MIT, and the only license which was GPL under the libBrowser/netsurf/ folder was the netsurf subfolder. The MIT license applied to my work which was in Urho3D-NetSurf\Source\Samples\60_NetSurf in .cpp and .h files, as indicated in the headers for those files.

But, you might be right that I might have violated the license for modifying the source files in libBrowser/netsurf/netsurf to be able to build with cmake and in Win32.

I've deleted the repo to avoid any complications. Thanks for mentioning this.
Lumak
Have many posts
Have many posts
 
Posts: 425
Joined: 08 Jun 2015, 15:38

Re: NetSurf integration to Urho3D

PostPosted by Enhex » 28 Oct 2016, 14:06

Err I meant that GPL requires any software that links to it to be also copyleft, so you're forced to release things that link to it (source code counts as linking?) under copyleft license too.
Again IANAL and only read short summaries about what GPLs allows and restricts (the thing is a giant wall of text).

You don't have to remove your repo, worst case you get infected by the viral license and forced to use it too.
User avatar
Enhex
Most active user
Most active user
 
Posts: 325
Joined: 31 Dec 2014, 12:23

Re: NetSurf integration to Urho3D

PostPosted by Lumak » 28 Oct 2016, 16:33

There were more MIT licenses than GPL under LibBrowser, though. But I get it. It does 'copy left' .

Anyway, I neglected to do this:
2. You may modify your copy or copies of the Program or any portion
of it, thus forming a work based on the Program, and copy and
distribute such modifications or work under the terms of Section 1
above, provided that you also meet all of these conditions:

a) You must cause the modified files to carry prominent notices
stating that you changed the files and the date of any change.


I changed many files in netsurf to be able to compile and run in Win32/MSVC and really don't want to deal with it. I hope everyone who was interested in this project got a copy :)
Lumak
Have many posts
Have many posts
 
Posts: 425
Joined: 08 Jun 2015, 15:38

Previous

Return to Developer Talk

Who is online

Users browsing this forum: No registered users and 0 guests

cron